Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add requires-python option to the project config #474

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Add requires-python option to the project config #474

merged 1 commit into from
Oct 26, 2023

Conversation

ogajduse
Copy link
Member

Problem statement

Since we deprecated Python 3.8 in #473, we should set the minimal Python version that wrapanapi requires in its project settings.

Solution

Add requires-python option to pyproject.toml and set it to 3.9+.

@ogajduse ogajduse requested a review from mshriver October 26, 2023 13:04
@ogajduse ogajduse self-assigned this Oct 26, 2023
@ogajduse
Copy link
Member Author

@mshriver Is it enough to add only requires-python? I can also add classifiers.

@mshriver
Copy link
Collaborator

requires-python is the important one, IIRC pip won't even list it if you're on an older version of python.

@mshriver mshriver merged commit 0a73a3c into RedHatQE:master Oct 26, 2023
4 checks passed
@ogajduse ogajduse deleted the add-minimal-py-version branch October 26, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshriver mshriver mshriver approved these changes

Assignees

@ogajduse ogajduse

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ogajduse @mshriver